Wireshark-bugs: [Wireshark-bugs] [Bug 9048] two pass analysis does not show any packets with som
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 18 Aug 2013 18:54:11 +0000

changed bug 9048

What Removed Added
Status UNCONFIRMED CONFIRMED
CC   eapache@gmail.com
Ever confirmed   1

Comment # 3 on bug 9048 from 
Yes, this looks good to me.

I think there is an additional issue: the second pass of two-pass mode may
process extra frames because max_packet_count is only decremented if "passed ||
fdata->flags.dependent_of_displayed". I think it is enough to move the "if
((--max_packet_count == 0) ...) { ... }" block outside of the "if
(process_packet_second_pass(...)) { ... }" block? If you agree you can commit
both changes.

The other question is backport for 1.10. I think it should be backported but I
am not sure, I don't want to break it for people who rely on the old behaviour.
Maybe it is better to leave it for the next major release?

(P.S. please explicitly CC me when you want my input, I am not subscribed to
the all-bugs mailing list and found this only by accident)

You are receiving this mail because:
  • You are watching all bug changes.