Wireshark-bugs: [Wireshark-bugs] [Bug 9050] Bluetooth: HCI/3DS and misc improvements
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 18 Aug 2013 00:57:10 +0000

changed bug 9050

What Removed Added
Attachment #11398 Flags review_for_checkin? review_for_checkin-

Comment # 6 on bug 9050 from 
Comment on attachment 11398 [details]
[PATCH 3] Bluetooth: Replace proto_tree_add_text with hf items

While I applaud the effort to replace proto_tree_add_text calls with something
filterable, there are many fields which are of type FT_NONE.  Upon cursory
glance, it appears many could have a real type to them.  I realize sometimes
multiple values are involved in a single field display, but does that mean
either:
1. One of the values should be chosen as filterable as an integer/string
2. More fields should be created

I don't think many more hf_ items need to be created (which I consider the
harder part), just the type changed to something that can "filter by value"
(and thus change proto_tree_add_none_format to
proto_tree_add_[uint|string]_format)

You are receiving this mail because:
  • You are watching all bug changes.