Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 9036] New: Dissector for EtherCAT: ADS highlighting in the Packet Bytes Pane i

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	9036
Summary	Dissector for EtherCAT: ADS highlighting in the Packet Bytes Pane is incorrect.
Classification	Unclassified
Product	Wireshark
Version	1.10.1
Hardware	x86-64
OS	Windows 7
Status	UNCONFIRMED
Severity	Minor
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	mvlc@telenet.be

Created attachment 11370 [details]
EtherCAT AMS capture

Build Information:
Version 1.10.1 (SVN Rev 50926 from /trunk-1.10)

Copyright 1998-2013 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.24.14, with Cairo 1.10.2, with Pango 1.30.1, with
GLib 2.34.1, with WinPcap (4_1_3), with libz 1.2.5, without POSIX capabilities,
without libnl, with SMI 0.4.8, with c-ares 1.9.1, with Lua 5.1, without Python,
with GnuTLS 2.12.18, with Gcrypt 1.4.6, with MIT Kerberos, with GeoIP, with
PortAudio V19-devel (built Jul 26 2013), with AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with WinPcap version
4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 2.12.18, Gcrypt 1.4.6, without AirPcap.
        Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz, with 4077MB of physical
memory.


Built using Microsoft Visual C++ 10.0 build 40219
--
For all EtherCAT AMS-packets, the highlighting of the ADS-bytes in the "Packet
bytes Pane" is incorrect. It's always 6 bytes too short from the end.

1. Open the capture file in attachment.
2. Open AMS.
3. Select ADS ReadWrite Request.
4. In the "Packet Bytes Pane" is the highlighting 6 byte to short.

This is the case for every AMS-packet.


File : wireshark/plugins/ethercat/packet-ams.c
Line : 417 ams_length -= TcpAdsParserHDR_Len;
Line : 419 offset = TcpAdsParserHDR_Len;

I think that line 417 can be deleted.
In line 419 the offset is already set 6 bytes ahead.

---

      You are receiving this mail because:

• You are watching all bug changes.