Wireshark-bugs: [Wireshark-bugs] [Bug 9033] wmem assertion after changing preferences before loa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 13 Aug 2013 01:50:40 +0000

Comment # 2 on bug 9033 from 
(In reply to comment #1)
> Applying the prefs is triggering rescan_packets which is triggering wmem to
> enter file scope.
> 
> #0  wmem_enter_file_scope () at wmem_scopes.c:99
> #1  0x00007ffff4e025be in init_dissection () at packet.c:186
> #2  0x00007ffff4df6b63 in epan_new () at epan.c:146
> #3  0x0000000000431eb7 in ws_epan_new (cf=0x81d980 <cfile>) at file.c:339
> #4  rescan_packets (cf=cf@entry=0x81d980 <cfile>,
> action="" "Reprocessing",
> action_item=action_item@entry=0x57c6e5 "all packets", 
>     redissect=redissect@entry=1) at file.c:1873
[...]

> There are probably two issues here:
> - rescan_packets should bail because there is no file open
> - if it doesn't bail, it should clean up the epan it creates so that wmem
> leaves file scope

- wmem shouldn't do stupid assertions.

> CCing Jakub; since this doesn't happen in 1.10 I suspect his epan_new
> changes triggered this.

epan_session introduction (r50761) was very clean, 
 - all cleanup_dissection() changed to epan_free()
 - all init_dissection() changed to epan_new()

I'd rather suggest blaming Jeff's r51188 ;] and reverting it fix a problem.

Hot potato...

You are receiving this mail because:
  • You are watching all bug changes.