Wireshark-bugs: [Wireshark-bugs] [Bug 8961] Enhancement: Add dissector for the STANAG 4607 GMTIF
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 02 Aug 2013 02:17:01 +0000

Comment # 8 on bug 8961 from 
(In reply to comment #7)
> The correct way to signal a corrupt packet is through the expert API,
> however I believe that proto_item_set_expert_flags is now deprecated. I have
> CCed Michael to double-check this, but I *think* that all expert API calls
> not taking an expert_field struct are being removed. Additionally, expert
> calls (like column calls) must occur regardless of whether or not the tree
> parameter is NULL.

I'm not sure of the origins of proto_item_set_expert_flags, but I believe at
this point its functionality should be "private" to the expert module (just
haven't removed all calls to it in the dissectors).

Looking at the patch, it appears you need expert_add_info (maybe
expert_add_info_text_format if you want to include the invalid size in the
printf string) and pass it the "item" returned from the segment size.
expert_add_info_text is being deprecated/converted.

You are receiving this mail because:
  • You are watching all bug changes.