Wireshark-bugs: [Wireshark-bugs] [Bug 8787] 9P dissector - compute fids on first visit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 01 Aug 2013 18:31:42 +0000

changed bug 8787

What Removed Added
Attachment #11193 is obsolete   1
Attachment #11314 Flags   review_for_checkin?

Comment # 23 on bug 8787 from 
Created attachment 11314 [details]
[PATCH] build fids on first pass, v5

Fixed the malloc, added checks for set/get tag/fid, and switched ep/se to wmem
since I apparently looked at an old checkout this morning and trees are here
alright.


The wmem change was mostly search and replace work and I didn't test it as much
as I'd have liked to, but it doesn't look like everything explodes so it might
just work. (does closing file take longer than it used to?)
wmem would allow a couple more minor changes (se_alloc didn't allow free, but
there are handled error cases which could now use it), but I had a look at the
g_malloc'd values and I guess it's probably safer to keep it that way.
It's just missing a finish routine to be completely clean :P

Anyway, that aside this is good for another fuzzing test or whatever you
torture these patches with, I'd do it myself but I'm not sure of what you do
exactly.

Thanks :)

You are receiving this mail because:
  • You are watching all bug changes.