Wireshark-bugs: [Wireshark-bugs] [Bug 8860] Enhancements to SEL Fast Message (selfm) Dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 03 Jul 2013 16:26:47 +0000

Comment # 5 on bug 8860 from 
Created attachment 11140 [details]
selfm patch 07-03-2013 - Compilation and HF/API check fixes

Evan,

Sorry about the compilation errors - same story as the original submission
where the Microsoft compiler doesn't complain nearly enough to me.  :)

I think I've got all those issues resolved, but I'm not 100% clear if I've
resolved the valgrind check.  From what I could tell, it appears that the
'Telnet Clean' function was reading a single byte beyond the end of it's
assigned src buffer length while processing the last byte in the buffer (and
checking for a dupe 0xFF).  I put in an 'if' statement to confirm that we are
NOT on the last byte while checking this so hopefully that resolves that
potential issue.

Let me know if anything else flushes out with these changes.

Thanks for your help,
Chris

You are receiving this mail because:
  • You are watching all bug changes.