Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8881] New: patch: (packet-scsi-osd.c) OSD-2 LIST - fix miscellaneous bugs from

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	8881
Summary	patch: (packet-scsi-osd.c) OSD-2 LIST - fix miscellaneous bugs from revision 50308
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Minor
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	uce@rjgodoy.com.ar

Created attachment 11126 [details]
patch

Build Information:

--
I've found some bugs in the code I contributed under revision 50308 (bug 8832).

hf_scsi_osd2_object_descriptor_format (OSD-2: "Object Descriptor Format",
Tables 107, 108) was initialized as "scsi_osd2.list_format", which is
inconsistent with the field name. 

Also, in dissect_osd_list:
 - the "list of user object ids or partition ids" loop for OSD-2 must *only* be
entered when the format is 0x01, 0x02, 0x21 or 0x22.         
 - If format is 0x02 or 0x22, each object descriptor has a multi-object
retrieved attributes format (conditional inside the loop).
 - If format is 0x01 or 0x02, the Data In buffer will contain partition
IDs/entries with partition IDs, otherwise it will contain user object
IDs/entries with user object IDs. Then the is_root variable (when dissecting
the Data In buffer in OSD-2 mode) must be computed as
(format==0x01||format==0x02) [or !(list_format&0x20)]     
 - there were some (gross) bugs in the code dissecting each entry.

An expert info (ei_osd2_invalid_object_descriptor_format PI_UNDECODED/PI_ERROR)
is now generated if the CDB cannot be dissected because the format is unknown.

---

      You are receiving this mail because:

• You are watching all bug changes.