Wireshark-bugs: [Wireshark-bugs] [Bug 8849] Buggy IEC104 dissector caused by commit r48958
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 28 Jun 2013 08:10:21 +0000

Comment # 15 on bug 8849 from 
Created attachment 11087 [details]
Patch for "Fix decoding of CP56time + code style changes v3"

Hello. I think there a error with definition of month value, because mktime()
use range between 0 and 11 for month value. Also there small change definition
of year value.

P.S. I think, that uses mktime() for output CP56time not good idea in any
cases, because mktime() return "-1" code if input timestamp will be before 1
January 1970. I have some *pcap, where timestamp is set to 01.01.70 00:31:28.
And because my timezone is UTC+4 in this case mktime() return "-1" code and in
cp56time_tree will be "CP56Time: Not representable".

You are receiving this mail because:
  • You are watching all bug changes.