Michael Mann
changed
bug 8844
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
CONFIRMED
|
| CC |
|
mmann78@netscape.net
|
| Component |
Wireshark
|
Dissection engine (libwireshark)
|
| Hardware |
x86
|
All
|
| Ever confirmed |
|
1
|
| Severity |
Major
|
Enhancement
|
Comment # 1
on bug 8844
from Michael Mann
Review comments:
1. You mention supporting a more recent version of the protocol, yet I don't
see any changes that are version specific. With this patch accepted is the
currently support version (that doesn't always assume the presence of a
checksum) now invalid?
2a. Adding offset in version >= 209 case is useless as no logic uses offset
following it (which is why it was commented out)
2b. No code for version > 70001, why include it?
3. Patch fails to compile on Windows:
packet-bitcoin.c(338) : error C2220: warning treated as error - no 'object'
file generated
packet-bitcoin.c(338) : warning C4244: 'function' : conversion from 'guint64'
to 'gint', possible loss of data
packet-bitcoin.c(348) : warning C4244: 'function' : conversion from 'guint64'
to 'gint', possible loss of data
packet-bitcoin.c(350) : warning C4244: '+=' : conversion from 'guint64' to
'guint32', possible loss of data
4. Has this code been fuzztested?
5. Please provide sample trace for future fuzztesting by the buildbots.
You are receiving this mail because:
- You are watching all bug changes.
