Wireshark-bugs: [Wireshark-bugs] [Bug 8633] New Dissector for Common Address Redundancy Protocol
      
      
    
     Michael Mann
 changed
              bug 8633
        
             
          
            | What | 
            Removed | 
            Added | 
          
         
           | Attachment #10976 is obsolete | 
           
                
            | 
           1
            | 
         
         
           | Attachment #10976 Flags | 
           review_for_checkin?
            | 
           
                
            | 
         
         
           | Attachment #10980 Flags | 
           
                
            | 
           review_for_checkin?
            | 
         
      
        
            Comment # 12
              on bug 8633
              from  Michael Mann
        Created attachment 10980 [details]
CARP dissector with pure heuristics
Here is a more pure heuristic approach to CARP.  I made the IP dissector able
to heurstically dissect its payload and added a heuristic hook for carp (that
could probably be strengthened to include valid version/type).  Trying
heuristics "first" is disabled by default (seems to be the convention), but
when enabled it correctly dissects the CARP packets.
I intentionally removed the expert info from the VRRP dissector (leaving it
unchanged), but I can see the argument for having it.  I just like to avoid
dissectors having to know about each other if there isn't a payloader/payloadee
relationship.  I could also see making a heuristic hook for the VRRP dissector,
but it appears it would have (incorrectly) claimed the CARP packets in the
provided captures.
         
      
      
      You are receiving this mail because:
      
      
          - You are watching all bug changes.