Wireshark-bugs: [Wireshark-bugs] [Bug 8787] 9P dissector - compute fids on first visit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 13 Jun 2013 18:14:05 +0000

Comment # 10 on bug 8787 from 
I took a little closer look today.  I think that separating all that logic into
that firstpass function is probably a complicated and risky way to do things. 
It effectively means we've got 2 pieces of code parsing the messages far enough
to process the fid.  You can imagine that 3 years from now someone might fix an
offset increment mistake in one but not the other.

Why not just put some "if not first pass, skip fid addition stuff" in the
existing dissection logic?

You are receiving this mail because:
  • You are watching all bug changes.