Wireshark-bugs: [Wireshark-bugs] [Bug 7676] tshark -q -z io, stat, 1 causes core dump for files
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 12 Jun 2013 21:55:49 +0000

Comment # 13 on bug 7676 from 
(In reply to comment #12)
> Patch for it's quite simple:
> 
> -    relative_time = (guint64)((pinfo->fd->rel_ts.secs*1000000) +
> ((pinfo->fd->rel_ts.nsecs+500)/1000));
> +    relative_time = (guint64)((pinfo->fd->rel_ts.secs*1000000U) +
> ((pinfo->fd->rel_ts.nsecs+500)/1000));
> 
> But whole code should be checked for 32 bits.

Actually I think we should first cast pinfo->fd->rel_ts.secs to guint64, with
above fix it'll still overflow on 32-bits for frame time > 4294s

or 1000000ULL but leaving this bug for Cal :>

You are receiving this mail because:
  • You are watching all bug changes.