Wireshark-bugs: [Wireshark-bugs] [Bug 8787] 9P dissector - compute fids on first visit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 12 Jun 2013 18:06:37 +0000

Comment # 5 on bug 8787 from 
(In reply to comment #4)
> (In reply to comment #3)
> > (I'm assuming dissectors register_init_routine is only called once when
> > wireshark start, and not at every capture start. If there's a fresh init
> > there I guess I could reset the hashtables at this point.)
> 
> That routine's supposed to be called when the capture file is closed and/or
> when a new one is opened--that's how most dissectors reset their built-up
> state between files.

Thanks.
I actually outsmarted myself and the init routine does free everything from the
hashtable on subsequent calls (guess it comes from where I found another init
routine), so it looks good to me if se_alloc stuff is freed at the same time.

Do you want me to repost the patch with the inverted flags.visited condition,
or shall I let you change it manually and take your time to review the patch?

You are receiving this mail because:
  • You are watching all bug changes.