Wireshark-bugs: [Wireshark-bugs] [Bug 8767] New: [PATCH] SDH dissector calculation fixes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 04 Jun 2013 03:17:36 +0000
Bug ID 8767
Summary [PATCH] SDH dissector calculation fixes
Classification Unclassified
Product Wireshark
Version SVN
Hardware All
OS All
Status UNCONFIRMED
Severity Normal
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter Anthony.Coddington@endace.com
Attachment #10923 Flags review_for_checkin? 

Created attachment 10923 [details]
Patch to fix SDH column calculations

Build Information:

--
The SDH dissector was incorrectly dissecting >STM-1 packets due to an error in
column offset calculations, as mentioned in bug 7490. This patch corrects these
calculations. I believe robustly fixing the reassembly support in that bug
would require a reasonably large amount of work, so I have based the patch on
the version of packet-sdh.c in trunk so that at least the current dissection
will behave correctly. The J1 pointer calculation will be incorrect during a
pointer movement, but should recover in the following frame.

I have also added an extension header iteration function to packet-erf to
generically check for a given type extension header, replacing the assumption
in packet-sdh that there will always be a raw link header as the first
extension header.

You are receiving this mail because:
  • You are watching all bug changes.