Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8747] GSM Cell Broadcast dissector displays padding (\r) characters

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 11 on bug 8747 from Reinhard Speyerer

> Hi Reinhard,
> 
> I guess it's allowed to have a <CR> in the middle of the CBS content.

Hi Pascal,

I think you are right, review_for_checkin flag cleared.
Since your code does not use cp the patch could IMO be simplified to

Index: epan/dissectors/packet-cell_broadcast.c
===================================================================
--- epan/dissectors/packet-cell_broadcast.c     (revision 49709)
+++ epan/dissectors/packet-cell_broadcast.c     (working copy)
@@ -265,6 +265,9 @@
      out_len = gsm_sms_char_7bit_unpack(0, length, sizeof(msgbuf),
                                         input_string,
                                         msgbuf);
+     while (out_len && msgbuf[out_len-1] == '\r') {
+       out_len--;
+     }
      msgbuf[out_len] = '\0';
      utf8_text = gsm_sms_chars_to_utf8(msgbuf, out_len);
      tvb_out = tvb_new_child_real_data(tvb, utf8_text, out_len, out_len);


Regards,
Reinhard

---

      You are receiving this mail because:

• You are watching all bug changes.