Wireshark-bugs: [Wireshark-bugs] [Bug 8756] New: gsm_a_dtap dissector (SMS): under certain condi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 02 Jun 2013 19:05:36 +0000
Bug ID 8756
Summary gsm_a_dtap dissector (SMS): under certain conditions fillbits may be displayed for an alphanumeric TP-Originating-Address
Classification Unclassified
Product Wireshark
Version 1.10.0
Hardware x86
OS All
Status UNCONFIRMED
Severity Minor
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter rspmn@arcor.de 

Created attachment 10897 [details]
example .pcap with alphanumeric TP-Originating-Address

Build Information:
wireshark 1.10.0rc2 (SVN Rev Unknown from unknown)

Copyright 1998-2013 Gerald Combs <gerald@wireshark.org> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.24.18, with Cairo 1.12.8, with Pango 1.32.5, with
GLib 2.34.3, with libpcap, with libz 1.2.7, without POSIX capabilities, without
libnl, without SMI, without c-ares, without ADNS, with Lua 5.1, without Python,
without GnuTLS, without Gcrypt, without Kerberos, without GeoIP, without
PortAudio, with AirPcap.

Running on Linux 3.7.10-1.11-default, with locale en_US, with libpcap version
1.3.0, with libz 1.2.7, without AirPcap.

Built using gcc 4.7.2 20130108 [gcc-4_7-branch revision 195012].

--
Under certain conditions fillbits may be displayed for an alphanumeric
TP-Originating-Address. Using the attached sms-with-alnum-tp-orig-addr.pcap
(Decode User DLT 0 as gsm_a_dtap) wireshark displays the
TP-Originating-Address as "o2 Team@" where a mobile would display "o2 Team":

    TP-Originating-Address - (o2 Team@)
        Length: 13 address digits
        1... .... :  No extension
        .101 .... :  Type of number: (5) Alphanumeric (coded according to 3GPP
TS 23.038 GSM 7-bit default alphabet)
        .... 0000 :  Numbering plan: (0) Unknown
        TP-OA Digits: o2 Team@

According to TS 23.040 section 9.1.2.5 "The Address-Length field is an
integer representation of the number of useful semi-octets within the
Address-Value field, i.e. excludes any semi octet containing only fill bits."

The proposed patch checks the length of the string returned from
gsm_sms_char_7bit_unpack and decreases the length according to the
definition above.

Please recheck the correctness of the if condition before committing the patch.

The patch is also applicable to the SVN trunk.

You are receiving this mail because:
  • You are watching all bug changes.