Wireshark-bugs: [Wireshark-bugs] [Bug 8728] NFS dissector infinite loop
Date: Thu, 30 May 2013 02:31:20 +0000

changed bug 8728

What Removed Added
CC   eapache@gmail.com

Comment # 3 on bug 8728 from
(In reply to comment #2)
> Oh, I also forgot to mention: it's not an infinite loop, just a very, very
> long one. ;-)
> 
> (I also forgot to make this bug public.)
> 
> Since I forgot to make it public, reiterate this comment with the broader
> audience:
> 
> BTW I'm confused: I can't reproduce this bug with tshark, only with
> Wireshark.

More tree weirdness.

In tshark running without -V runs with tree==null, so the loop is at least very
fast (though it does run a ridiculous number of times, which is the bug) and
there is no "too many items" warning because proto_tree_add_item is never
called.

In tshark running with -V runs with a fully functional tree, so the loop goes
off the end of the TVB and throws an exception very quickly.

In wireshark, however, we run with a 'hidden' tree, so tree is non-null
(causing proto_tree_add_item to actually be called) however
TRY_TO_FAKE_THIS_ITEM counts the calls (leading to the "too many items"
warning) but still short-circuits before an exception can be thrown.

Basically you are seeing the bug in tshark with no tree, it just doesn't
display the warning and runs relatively fast because the loop is so tight in
that case.

I don't know if it's possible to make tshark run with a hidden tree or not...


You are receiving this mail because:
  • You are watching all bug changes.