Wireshark-bugs: [Wireshark-bugs] [Bug 8691] Adding support of BGP flow spec RFC 5575
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 19 May 2013 23:09:23 +0000

Comment # 11 on bug 8691 from 
Hi Alexis,

One more thing with regards to this value, its description also depends on the
branch that has been chosen and define by the NLRI type value... It creates an
additional complexity to use proto_tree_add_item. As fars as I know,
proto_tree_add_item is mainly used for item's that are present in the protocol
when we enter a specific tree. The problem with this value is that, whitin the
tree depending of op-value pair type, this value could have different meanings:
a TCP port port, UDP port, packet lenght, ...

Operator format also depends on value and NLRI type, it could be a certain
bitmask for decimal values and a diff one for values that are nitmask... That's
why I did some un-optimised function and doing copy/paste because each case was
quiet specific.

Not sure, I can optimise more the code as it is now ...

Let me know if you want me to post the revisited version ...

Thanks Matt.

You are receiving this mail because:
  • You are watching all bug changes.