Comment # 25
on bug 8573
from Evan Huus
Thanks for the updated patch. I will check the correct behaviour of Data
dissector when I get a chance, I think it should be working the way you've got
it.
Some additional notes:
- you've made some whitespace changes to Makefile.common, why?
- please end value_strings with explicit 0 and NULL. Using an enum for the zero
is confusing as it makes it look like a real entry
- you can pass a length of -1 to most proto_tree_* functions to mean 'the rest
of the packet' instead of explicitly calling tvb_length_remaining()
- indentation is a bit odd in places (it looks like some lines aren't indented
at all?)
- tools/checkhf.pl complains:
Unused entry: epan/dissectors/packet-ptpip.c, hf_ptp_data
Unused entry: epan/dissectors/packet-ptpip.c, hf_ptp_eventCode
- tools/checkAPI.pl complains:
Error: the blurb for hf_ptpIP_len ("ptpip.len") matches the field name in
epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptpIP_guid ("ptpip.guid") matches the field name in
epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptpIP_version ("ptpip.version") matches the field name
in epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptpIP_connectionNumber ("ptpip.connection") matches the
field name in epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptpIP_dataPhaseInfo ("ptpip.phaseinfo") matches the
field name in epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptp_opCode ("ptpip.opcode") matches the field name in
epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptp_respCode ("ptpip.respcode") matches the field name
in epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptp_transactionID ("ptpip.transactionID") matches the
field name in epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptp_totalDataLength ("ptpip.datalen") matches the field
name in epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptp_data ("ptpip.data") matches the field name in
epan/dissectors/packet-ptpip.c
Error: the blurb for hf_ptp_opCode_param_sessionID
("ptpip.opcode.param.sessionid") matches the field name in
epan/dissectors/packet-ptpip.c
Error: Found C++ style comments in epan/dissectors/packet-ptpip.c
- typo: dissecct_ptp_transactionID
You are receiving this mail because:
- You are watching all bug changes.
