Wireshark-bugs: [Wireshark-bugs] [Bug 7060] Global variables - Buildbot crash output: fuzz-2012-
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 01 May 2013 21:05:47 +0000

Comment # 11 on bug 7060 from 
(In reply to comment #10)
> Removed all but one of the global varibles from the files referenced in the
> patch using Anders' suggestion of private_data member of asn1_ctx_t in
> r49117.  
> 
> Looks like that solution could be applied to many more global variables in
> the ASN.1 dissectors.  Should this bug remain open for them?  

I seem to remember attempting to do that to fix another problem, but the simple
solution didn't work; I forget why.  (Not that this shouldn't be done - Global
Variables Considered Harmful - but that we need to be careful when we do so. 
Maybe I should try one of my big regression tests between the code without this
change and the code with it.)

You are receiving this mail because:
  • You are watching all bug changes.