Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8616] Update Skinny Dissection Code (CM7.1 + / SPCP Message)

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 3 on bug 8616 from Diederik de Groot

(In reply to comment #2)
> (In reply to comment #0)
> > Important: Switched of returning 'FALSE' in dissect_skinny (line 3260) to
> > make this patch work. This is not correct, but i could not find the solution
> > to make this work correctly. 
> 
> This is a basic "heuristic" check for the protocol.  If the "header version"
> isn't one of the types listed, then it probably (in the mind of the
> dissector) isn't a skinny packet and another dissector should get a shot at
> it.  Do your traces have additional "header version" values?  If so they
> should be added to the if statement (or even better you can convert the if
> statement to using try_val_to_str with the header_version value_string and
> append your additional header version values there).

Hi Michael,

I do understand what it should do, but i could not get it to work correctly on
SPCP message (Message that use protocol version 0x16, which i added). I did not
find a way to output some debugging information, to get to grips with the
reason why it would not work as i would have expected it to.

I have also provide a capture, which it should be able to parse. But without
commenting out the 'return FALSE' statement, it would not work.

BTW: In the meantime i have a couple of message which are not parsed cleanly
either. Some more work is needed in this aria.

P.S. Any comment regarding the request for a joint protocol definition / idl
which might benefit both our projects ?

---

      You are receiving this mail because:

• You are watching all bug changes.