Wireshark-bugs: [Wireshark-bugs] [Bug 8610] RTP DTMF digits are no longer displayed in VoIP grap
Comment # 6
on bug 8610
from Guy Harris
(In reply to comment #3)
> Agree with Japp that the flags.in_error_pkt is odd - I traced it back to
> r9051 whose commit log says: "RTP packets are passed to the tap queue only
> if they are not error packets (so that you don't need to filter out ICMP
> packets)". Does this make more sense to somebody familiar with the protocol?
The reason why we run the payload of ICMP XXX Unreachable packets (and the OSI
network layer equivalent) through the dissector chain is so that you can tell
*which* packet failed to be delivered (an interesting enhancement might be a
way to identify the packet and link it, if present, but that'd require keeping
track of IP-layer IDs and endpoints and the equivalent for the OSI CLNP).
That means, unfortunately, that some packets show up twice (if the failing
packet was in the capture) and that dissectors have to know what's a "real"
packet (and should contribute to, for example, statistics) and what's not.
That's what flags.in_error_pkt is for.
You are receiving this mail because:
- You are watching all bug changes.
