Wireshark-bugs: [Wireshark-bugs] [Bug 8605] NFSv4 ACL-ACE tree and conversion of text to field n
Comment # 7
on bug 8605
from Cal Turney
(In reply to comment #6)
> Looks generally great, just one quick question: Wireshark provides an API
> (proto_tree_add_bitmask and friends) for easily adding bitfields (and
> permitting filtering on individual bits). Any particular reason you avoided
> it for hf_nfs4_aceflag, or were you just not aware?
I considered using proto_tree_add_bitmask() but realized that the bitmap tree
would show all the possible flag settings including
ACE4_SUCCESSFUL_ACCESS_ACE_FLAG. In 99.9999% of the cases that bit would NOT be
set. According to RFC 5661:
The ACE4_SUCCESSFUL_ACCESS_ACE_FLAG (SUCCESS) and
ACE4_FAILED_ACCESS_ACE_FLAG (FAILED) flag bits may be set only on
ACE4_SYSTEM_AUDIT_ACE_TYPE (AUDIT) and ACE4_SYSTEM_ALARM_ACE_TYPE
(ALARM) ACE types.
I was concerned that users might conclude that the ACE was configured on the
server but was being ignored. I think it is safer to only display these flags
in ALARM or AUDIT ACEs which, by the way, are very rare in my experience.
You are receiving this mail because:
- You are watching all bug changes.
