Wireshark-bugs: [Wireshark-bugs] [Bug 8573] New Dissector Patch - PTP/IP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 20 Apr 2013 21:04:21 +0000

Comment # 15 on bug 8573 from 
(In reply to comment #14)
> Thanks for the code review Evan.  
> 
> (In reply to comment #12)
> > Would one of you like to extract some common code into a separate patch that
> > can be merged first, or would you prefer the two dissectors are committed
> > separately and then common code added later?
> 
> I'd prefer to commit them first then merge them in a future patch. 

OK

> One thing I have questions about.  The Percision Time Protocol dissector
> also is abbrievated PTP.  For the common code between both PTP/USB & PTP/IP
> would there be any issue labeling it PTP?

Hmmm, good point. Perhaps the Picture Transfer Protocol should be abbreviated
pictp? Or the Precision Time Protocol should be changed to ptime or
something... I guess it depends on which protocol is more common for people to
use.

You are receiving this mail because:
  • You are watching all bug changes.