Wireshark-bugs: [Wireshark-bugs] [Bug 8581] NFS Dissector : More intuitive and less ambiguous va
Comment # 18
on bug 8581
from Cal Turney
NFS variable names and labels should be more inituitive and less ambiguous;
version-specific routines should be identified as such; and general readability
changes are needed for users and developers. The patch includes the following:
* Filter name "rpc.array.len", the number of ACEs returned in the response,
changed to "nfs.num_aces"
* "hf_nfs_cookieverf4" was changed to "hf_nfs_cookie_verf4"
* "ett_nfs4_fattr4..." names were changed to "ett_nfs_fattr4..." in conformance
with the naming convention of that list
* A space was added after the colon in <name:value> strings in the Info column
(e.g., "FH:0x%08x" to "FH: 0x%08x" and "Error:%s" to "Error: %s").
* "bitmap_len" which sounds like it might be the size of one or more bitmaps
is actually the number of bitmaps. It was renamed "num_bitmaps".
Similarly, "MAX_BITMAP_LEN" was changed to "MAX_BITMAPS".
* Lines wider than 102 bytes were divided.
* The routine names that did not indicate an NFSv2 version indication but
were in fact v2-specfic were renamed (e.g., 'dissect_ftype()' was
renamd "dissect_nfs2_ftype"
* All of the variable names and labels in the form:
xxxx_nfs_yyyy<2|3|4>
were renamed:
xxxx_nfs<2|3|4>_yyyy
For example: "dissect_nfs_nfsstat4" was renamed ''dissect_nfs4_status".
* Uninitialized *proto_tree; and *proto_item; variables were initialized to
NULL.
* Most of the mode (permission) types in the "recc_attr: FATTR4_MODE (33)"
subtree were incorrectly labeled as:
"Read permision for <owner | group | others>" instead of
"<Write | Execute> permission for <owner | group | others>"
This has been corrected.
You are receiving this mail because:
- You are watching all bug changes.
