Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8589] New: [PATCH] 9P dissector enhancement

[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	8589
Summary	[PATCH] 9P dissector enhancement
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	All
OS	All
Status	UNCONFIRMED
Severity	Enhancement
Priority	Low
Component	Wireshark
Assignee	bugzilla-admin@wireshark.org
Reporter	xvnfrhr.unzneqfjef@noclue.notk.org

Created attachment 10602 [details]
9P protocol enhancement patch

Build Information:

--
Theses patches add alot of new message types for the 9P protocol and its
extensions (most specifically 9P2000.L), while staying compatible with the
legacy protocol (hence the hashtable with conversation information, since
version is only known at handshake)
It is still missing alot of 9P2000.u specifics, but I don't have any server to
test it with. I'm also missing some dump to test legacy, but I'm pretty
confident I didn't break much there as it is mostly compatible, most
differences are handled using different messages, the only one that was changed
would be RERROR.


second diff also adds deeper interpretation of the protocol, by following the
conversation stream and keeping a bigger hashtable associating fid (file
handles) and file names, for easier debugging.
It is probably not good as it is, given it assumes packets are dissected once
(and only once) in the stream order, which is not the correct. Any hint there
is welcome.
(there's a whole follow-fid diff that contains everything from svn base, and a
git diff that only contains what's new in it. I'm afraid I don't know how to
commit changes locally in svn to produce partial diffs...)



Anyway, any feedback is welcome, I spent quite some time on this so a few more
hours won't hurt if I did something wrong ;)

---

      You are receiving this mail because:

• You are watching all bug changes.