Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8584] support for NFSv4.1 open access modes including delegation wants

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 7 on bug 8584 from J. Bruce Fields

(In reply to comment #5)
> Just a weird corner of the API. I assume the parent bitfield is 4 bytes/32
> bits?

Yeah, it's a 32-bit field, though really only 2 bits of it are currently used
as a bitfield.  Anyway, I guess the change would look like?:

diff --git a/epan/dissectors/packet-nfs.c b/epan/dissectors/packet-nfs.c
index 8b606d6..c80e4cd 100644
--- a/epan/dissectors/packet-nfs.c
+++ b/epan/dissectors/packet-nfs.c
@@ -11351,11 +11351,11 @@ proto_register_nfs(void)
                        NULL, 0, NULL, HFILL }},
                { &hf_nfs_want_signal_deleg_when_resrc_avail, {
                        "want_signal_deleg_when_resrc_avail",
-                       "nfs.want_notification.when_resrc_avail", FT_BOOLEAN,
BA
+                       "nfs.want_notification.when_resrc_avail", FT_BOOLEAN,
32
                        TFS(&tfs_set_notset),
OPEN4_SHARE_ACCESS_WANT_SIGNAL_DEL
                { &hf_nfs_want_push_deleg_when_uncontended, {
                        "want_push_deleg_when_uncontended",
-                       "nfs.want_push_deleg_when_uncontended", FT_BOOLEAN,
BASE
+                       "nfs.want_push_deleg_when_uncontended", FT_BOOLEAN, 32,
                        TFS(&tfs_set_notset),
OPEN4_SHARE_ACCESS_WANT_PUSH_DELEG

                { &hf_nfs_seqid4, {

I don't actually have any example traffic that uses those two bits and haven't
checked what that would look like.

---

      You are receiving this mail because:

• You are watching all bug changes.