Wireshark-bugs: [Wireshark-bugs] [Bug 8581] NFS Dissector : More intuitive and less ambiguous va
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 15 Apr 2013 21:38:15 +0000

Comment # 12 on bug 8581 from 
(In reply to comment #10)
> (In reply to comment #9)

> Because that is
> conditional on if (tree) while the variable is then used in a subsequent
> switch conditional regardless of tree.

I must have been half asleep when I made that statement.  Anyway, I've
corrected it.  Thanks. 

> Ah,
> there was an additional reference added in r48849 which was committed after
> you posted your patch. I can fix that myself if necessary.

I will submit the new patch under r48849 so you don't have to worry about it.
Thanks for you help on this one. 

I just found a bug where the NFSv3 error list was being used in an NFSv4
routine. That is why it's a good idea to add the version number in
(version-specific) lists, variable names, and routine names. In addition,
changing *_nfs_*4 to *_nfs4_* makes it even less likely that mistakes will be
made.

I'm taking my time my time on these changes to make certain they are right.

You are receiving this mail because:
  • You are watching all bug changes.