Wireshark-bugs: [Wireshark-bugs] [Bug 8573] New Dissector Patch - PTP/IP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 12 Apr 2013 02:54:51 +0000

Comment # 3 on bug 8573 from 
Hi Jaap,

Thanks for the quick code review turnaround.

* Tabs placed back in Makefile.common
* Column check removed
* Enclosed setting of column by if (tree) removed.
* Enclosed calling of subdissector removed.
* Many values that were pulled from the TVB and unchanged when added back have
been replaced with proto_tree_add_item().  The one's that haven't been replaced
were also being put into the col info or used in some sort of conditional.
* Removed many of the tvb_length_remaining() conditionals.
* Converted the tabs to spaces.  Sorry about that my IDE had this weird glitch
were I couldn't put spaces in with the tab key, even if I had it there in the
settings.

You are receiving this mail because:
  • You are watching all bug changes.