Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8505] openSAFETY: New reassemble functionality, as well as minor bugfixes

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 31 on bug 8505 from Roland Knall

Hi

Hope your exams go well

(In reply to comment #29)
> - Instead of calling tvb_ensure_bytes_exist and wrapping it in a manual
> TRY/CATCH block, you can instead just call tvb_bytes_exist which returns a
> boolean.

Done

> - You do a lot of shifts of the style "( x >> 2 ) << 2" which I imagine is
> just to zero the rightmost two bits of the value? If that's the case then it
> is probably clearer and probably more efficient to just do "( x & 0xFC )".

Done

> - You do:
> 
>     frameCRC = tvb_get_guint8(...);
>     if (dataLength > OSS_PAYLOAD_MAXSIZE_FOR_CRC8)
>         frameCRC += (tvb_get_guint8(... + 1) << 8);
> 

Changed

> - Trunk has recently enabled -Wc++-compat as an error so it's not
> technically compiling at the moment (just missing a cast I think).

Done

Additionally, I also added a check for faulty packages, which where previously
wrongfully detected, and prevented real frames from being detected correctly.

And also changed the order of hf_oss_snmt_master/slave, so that all reflect
exactly the same (master first, then slave)

kind regards,
Roland

---

      You are receiving this mail because:

• You are watching all bug changes.