Wireshark-bugs: [Wireshark-bugs] [Bug 8573] New Dissector Patch - PTP/IP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 10 Apr 2013 06:34:28 +0000

Comment # 2 on bug 8573 from 
Quick review:

* Keep the tabs in Makefile.common
* No checks on column needed, just set them
* Never enclose setting of column by "if (tree)'
* Never enclose calling a subdissector by "if (tree)'
* Don't go around getting values, only to add them to the tree unchanged.
  Define a proper header field and use proto_tree_add_item()
* Do not check tvb_length_remaining() all the time. 
  The TVB covers all that for you, and btw it's done wrong. 
* If you insist using tabs in your source lines you have to include modelines

You are receiving this mail because:
  • You are watching all bug changes.