Wireshark-bugs: [Wireshark-bugs] [Bug 8565] New dissector for PULSE protocol for Linux Virtual S
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 06 Apr 2013 11:22:25 +0000

changed bug 8565

What Removed Added
Attachment #10553 Flags review_for_checkin? review_for_checkin-

Comment # 2 on bug 8565 from 
Comment on attachment 10553 [details]
The dissector

Quick review:

* If you are determining endianness, you don't need 4 entries in
pulse_magic_type
* You may want to use try_val_to_str() i.s.o. val_to_str()
* Use of check_col() is deprecated, you can drop them
* Calling col_set_str() inside an 'if (parent_tree)' block is a no-no
* proto_tree_add_item() no longer takes gboolean

You are receiving this mail because:
  • You are watching all bug changes.