Wireshark-bugs: [Wireshark-bugs] [Bug 8506] VRT Protocol: VITA 49 Radio Transport Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 02 Apr 2013 18:35:39 +0000

Comment # 29 on bug 8506 from 
(In reply to comment #28)
> (In reply to comment #26)
> > Created attachment 10501 [details]
> > Bugfix patch improved
> > 
> > Referring to comment #c25: it was not intentional. Fixed by this patch.
> 
> Regarding the FT_BOOLEAN changes, this patch looks wrong to me.  The
> bitmasks should not be zero according to
> http://wdv.com/Electronics/Reference/SDROoverWEB-VITA.pdf.

>From my understanding, BITMASK is needed if you use proto_tree_add_item but not
if you use proto_tree_add_bits_item. So the current code seems OK and the call:
proto_tree_add_bits_item(trailer_tree, hf_vrt_trailer_e, tvb, offset * 8, 1,
ENC_NA);
should select the right bit.

You are receiving this mail because:
  • You are watching all bug changes.