Wireshark-bugs: [Wireshark-bugs] [Bug 8522] Add heuristic to dissect DVB-S2 over ethernet
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 25 Mar 2013 12:47:51 +0000

changed bug 8522

What Removed Added
Status UNCONFIRMED INCOMPLETE
CC   eapache@gmail.com
Ever confirmed   1

Comment # 1 on bug 8522 from 
I don't think this will quite work the way you expect? The ethernet dissector
shouldn't be passing the ethernet header in the tvb to
dissect_dvb_s2_modeadapt_eth, so there should be no need to skip it. Skipping
it the way you've done also (I think) makes the function return an incorrect
offset? You would have to add ETHERNET_HEADER_SIZE to the result of
dissect_dvb_s2_modeadapt.

In general I think everything should just work if you register
dissect_dvb_s2_modeadapt directly as a heuristic on UDP and Ethernet, and don't
create the extra functions at all. Do you have a capture to test with that you
could attach?

Thanks,
Evan

You are receiving this mail because:
  • You are watching all bug changes.