Wireshark-bugs: [Wireshark-bugs] [Bug 8357] Lua __tostring() metamethod of FieldInfo can cause e
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 23 Feb 2013 00:11:02 +0000

changed bug 8357

What Removed Added
Status CONFIRMED RESOLVED
Resolution --- FIXED

Comment # 4 on bug 8357 from 
(In reply to comment #3)
> Sorry about the indentation getting screwed up in the patch, but that
> probably caused you to think there was a duplicate return statement - there
> wasn't.  There really are 2 return statements: one if an error, one which
> returns 1.  The error case was after an 'else', but that 'else' did not make
> it into your delivery.  I should have wrapped the return statement in {}
> after the else to make it obvious.
> 
> So, unfortunately this means the function as delivered into trunk will
> always error, instead of only error'ing on an actual error.
> :(

Sorry about that. Fixed it in r47828, then inverted the if statement in r47829
so that it's in a more usual (and understandable) form.

You are receiving this mail because:
  • You are watching all bug changes.