Wireshark-bugs: [Wireshark-bugs] [Bug 8374] New: Make TDMoE dissector call LAPD dissector on D-C
Date: Thu, 21 Feb 2013 21:19:56 +0000
Bug ID 8374
Summary Make TDMoE dissector call LAPD dissector on D-Channel
Classification Unclassified
Product Wireshark
Version SVN
Hardware x86
OS Ubuntu
Status UNCONFIRMED
Severity Major
Priority Low
Component Dissection engine (libwireshark)
Assignee bugzilla-admin@wireshark.org
Reporter tim.ringenbach@gmail.com

Created attachment 10083 [details]
Patch described in bug

Build Information:

--
This patch makes the TDMoE dissector call the LAPD bitstream dissector on the
D-Channel. As a result, LAPD calls Q.931, and you can actually see call setup
and tear down, instead of just a hex dump.

It adds a preference for which channel the D-Channel is.

It patches the LAPD code to fix a few bugs, not pass the checksum to Q.931 (who
isn't expecting it), to register the lapd-bitstream dissector, and to mark
packets with aborts or resets.

The "Abort! 6 ones that don't match 0x7e!" turned out to be what I was looking
for in my motivating capture, but I didn't know that going in.

I'm also storing more data on the lapd_byte_state_t. In retrospect, I'm not
sure that was required. It seemed to be required, but I think it become not
required after I removed the "if (tree)" TDMoE. I haven't had time to try
reverting it.

It also comments out a line in ui/gtk/voip_calls.c. Commenting out that line
makes the TDMoE calls show up in the Voip Calls dialog. But I'm not sure if
that's really how you want that done.


You are receiving this mail because:
  • You are watching all bug changes.