Wireshark-bugs: [Wireshark-bugs] [Bug 8313] new dissector for SML protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 18 Feb 2013 16:31:38 +0000

changed bug 8313

What Removed Added
Attachment #10044 Flags   review_for_checkin?

Comment # 27 on bug 8313 from 
Created attachment 10044 [details]
small_sml_patch

- one more define added
- removed data_handle (unused)
- removed "check = tvb_get_guint8(tvb, temp_offset);" (value hasn't changed)
- added PI_NOTE 
- CRC fixed, calculation now correct if CRC is transmitted as UINT8

I thinks its not safe to make the SML dissector heuristic. If the SML - File is
split and the package starts with a message, only the first octet is fix. You
need more than just a few octets from the beginning, to make sure its SML.

You are receiving this mail because:
  • You are watching all bug changes.