Wireshark-bugs: [Wireshark-bugs] [Bug 8331] [BACnet] UCS-2 strings longer than 127 characters do
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 15 Feb 2013 19:35:18 +0000

Comment # 4 on bug 8331 from 
(In reply to comment #3)
> Hi Lori, thanks for the patch. I changed it in r47675 to use 256-byte
> chunks, since that is a power of two and does better things for the memory
> allocator.
> 
> Tangentially, why are we breaking it into such small chunks? Were there
> cases where a large string was being used and causing problems? It would be
> simpler to just grab the entire thing once rather than looping through
> chunks of it...
> 
> Michael, the other MIN calls don't seem related to me.

Evan, I don't know why the code is splitting it into chunks.  I figured there
must have been a reason to do it this way so I left it.  I agree that the 256
sounds like a better number.  Thanks.

You are receiving this mail because:
  • You are watching all bug changes.