Wireshark-bugs: [Wireshark-bugs] [Bug 2992] SDP must reject an offered stream if port is set to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 10 Feb 2013 21:52:09 +0000

Comment # 11 on bug 2992 from 
(In reply to comment #10)
> Provided a fix in rev 47564 when also fixing bug 2368.  Awaiting more
> testing before closing.

With r47564, Coverity 980630 reports: Negative array index read.  @Michael,
since this code is probably still fresh in your mind, maybe you could take a
look at it?  I didn't see your name listed in Coverity yet, so below is the
meat of the code that leads to the warning:

1724  if (transport_info == NULL) {
1725    transport_info = se_alloc0(sizeof(transport_info_t));

CID 980630 (#1 of 1): Negative array index read
(NEGATIVE_RETURNS)var_tested_neg: Assigning: "transport_info->media_count" = a
negative value.
1726    transport_info->media_count = -1;

...

1905    /* Free the remaining hash tables not used */

var_assign: Assigning: signed variable "n" = "transport_info->media_count".

At conditional (16): "n < 4" taking the true branch.
1906    for (n = transport_info->media_count; n < SDP_MAX_RTP_CHANNELS; n++)
1907    {

negative_returns: Using variable "n" as an index to array
"transport_info->media".
1908      rtp_free_hash_dyn_payload(transport_info->media[n].rtp_dyn_payload);
1909    }

You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.