Wireshark-bugs: [Wireshark-bugs] [Bug 8240] Dissector for the OpenVPN Protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 21 Jan 2013 19:23:56 +0000

changed bug 8240

What Removed Added
Attachment #9851 Flags review_for_checkin? review_for_checkin-

Comment # 12 on bug 8240 from 
Comment on attachment 9851 [details]
openvpn dissector patch

Comments:

1. It seems to me that the tls_auth_override related code doesn't 
   work as I think you meant it to work.

   If pref_tls_auth_override is TRUE, then pref_tls_tls_aut is always set
   to FALSE.

   If the override is TRUE, then is the tls_auth value (T/F) to be used
   always ?

   Please review.

   In any case, changing the value of a pref in the code is normally (always ?)
   not correct.


(Since there's a separate issue, I'll just list the following altho I'd
normally just fix them).

1. Compilation fails: missing include epan/wmem/wmem.h

2. de paket --> the packet
   wether --> whether
   paket --> packet

3. Please group all the prefs variables under /* Preferences */

You are receiving this mail because:
  • You are watching all bug changes.