Wireshark-bugs: [Wireshark-bugs] [Bug 8243] Update the FeliCa dissector to identify FeliCa Stand
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 21 Jan 2013 18:56:31 +0000

Comment # 5 on bug 8243 from 
(In reply to comment #4)
> Comment on attachment 9847 [details]
> A version of the patch with fixed brackets
> 
> Can the "commands" be switched to a single value_string, so there can just
> be a single col_set_str(pinfo->cinfo, COL_INFO, val_to_str(...)) then
> followed by a switch statement that dissects known commands further?

I assume that you're thinking of collapsing the commands, and responses tables
into a single opcodes one, too? (As suggested previously).

If so, I'll have a play with the code, and try to make a revised patch.

You are receiving this mail because:
  • You are watching all bug changes.