Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8239] Dissector for Microsofts SSTP VPN Protocol

[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 8239

What	Removed	Added
Status	UNCONFIRMED	CONFIRMED
Ever confirmed		1

Comment # 8 on bug 8239 from Alexis La Goutte

Hi,

Nice !
a quick review.

proto_tree_add_text(sstp_tree, tvb, offset, 0, "Attribute %s",
sstp_attributes[attrib_id].strptr);
Why not use val_to_str ? 

the checkhf script reports a unused hf_ entry 
Unused entry: epan/dissectors/packet-sstp.c, hf_sstp_hash_protocol_bitmask

the chechAPIs script reports also a warning :
Warning: epan/dissectors/packet-sstp.c does not have an SVN Id tag.

the fix-encoding-args script reports some errors :
epan/dissectors/packet-sstp.c:  FT_BYTES:        
proto_tree_add_item(sstp_tree, hf_sstp_reserved, tvb,     SSTP_OFFSET_RESERVED,
SSTP_FSIZE_RESERVED, [[ENC_BIG_ENDIAN]-->[ENC_NA]]);
epan/dissectors/packet-sstp.c:  FT_BYTES:        
proto_tree_add_item(sstp_tree_attribute, hf_sstp_reserved, tvb, offset,
SSTP_FSIZE_RESERVED2, [[ENC_BIG_ENDIAN]-->[ENC_NA]]);
...

Clang compile found a (small) warning
packet-sstp.c:316:15: warning: Value stored to 'hashproto' is never read

It is possible to add also modelines info ? (see
http://www.wireshark.org/tools/modelines.html )

It would be appreciated if you could add a page to wiki.wireshark.org about
this protocol (how to use and get the certificate...) :

(From doc/README.developer)

  - Create a Wiki page on the protocol at <http://wiki.wireshark.org>.
    A template is provided so it is easy to setup in a consistent style.
      See: <http://wiki.wireshark.org/HowToEdit>
      and  <http://wiki.wireshark.org/ProtocolReference>

---

      You are receiving this mail because:

• You are watching all bug changes.