Wireshark-bugs: [Wireshark-bugs] [Bug 2274] "Restart the running live capture" when using multip
Michael Mann
changed
bug 2274
What |
Removed |
Added |
Attachment #9700 Flags |
|
review_for_checkin?
|
Comment # 1
on bug 2274
from Michael Mann
Created attachment 9700 [details]
Bugfix long filenames
Here's what appears to be going on:
1. Wireshark provides dumpcap the original write file via -w,
capture_opts->save_file
2. Because of the ringbuffer options, dumpcap "returns" a new write filename
(save_file + current time) to use and Wireshark saves it to
capture_opts->save_file
3. When Wireshark capture is restarted capture_opts->save_file is used as the
"seed filename" for a new ring. Repeat Step 2.
So my solution is to save original file name and restore it on a restart.
Seems a bit kludgy, but it works.
One thing missing from the patch is when to free the orig_save_file memory.
Because a "restart capture" does a "stop capture", you can't free
orig_save_file then because it needs to persist between captures. It's not a
huge chunk of memory, but its the principle.
You are receiving this mail because:
- You are the assignee for the bug.
- You are watching all bug changes.