Wireshark-bugs: [Wireshark-bugs] [Bug 7960] Buildbot crash output: fuzz-2012-11-06-1334.pcap
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 02 Dec 2012 18:16:11 +0000

Comment # 4 on bug 7960 from 
(In reply to comment #3)

> Martin, if you can still reproduce it, maybe TVB_SET_ADDRESS() should call
> tvb_get_ptr() and set the data field in 2 steps.  (I would think that an
> exception being thrown in a function whose return value is being stored in a
> variable would mean that the variable is not modified, but what do I know?)

your change fixed the issue for me. I don't see the unhandled exception any
more.

I don't quite understand the underlying problem, though.
Apparently, SET_ADDRESS(..., tvb_get_ptr()) causes problems when tvb_get_ptr()
throws an exception. Moving it anywhere outside the macro parameters, either
befor the macro or inside it, fixes things. Is the return value undefined if
tvb_get_ptr() throws an exception?

Regards,

   Martin

You are receiving this mail because:
  • You are watching all bug changes.