Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8015] L2TP filtering on AVPs "Called Number" and "Calling Number"

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8015

--- Comment #2 from Andy Karch <akk142@xxxxxxxxx> 2012-11-23 12:57:11 PST ---
I have a few points to verify with the diff (and understand the rationale):

    - Should the hf_register_info->header_field_info->type 'ftenum' be
      FT_STRING or FT_STRINGZ?  What is the difference?  It says to use
      FT_STRINGZ with proto_tree_add_item(), but why is it different?

    - Is ENC_ASCII the right argument for proto_tree_add_item? RFC2661 says the
      AVP contents is ASCII. Seems obvious, but I just want to be sure.

    - It appears that the ASCII payload could have length '0' (avp length 6),
      where there is no space for the NULL terminating character. In this case,
      'avp_len' would be '0' due to subtractions for the AVP header. Would the
      '0' length sufficiently protect against overrunning the AVP payload? I
      assume the 'length' argument to proto_tree_add_item() has the protection
      for missing NULL termination, but I want to be sure.

Thanks,
-Andy

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.