Wireshark-bugs: [Wireshark-bugs] [Bug 6645] Patch to add support for Friendly Names for interfac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 19 Nov 2012 00:10:54 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6645

--- Comment #21 from Mike Garratt <wireshark@xxxxxxxxx> 2012-11-19 00:10:52 PST ---
(In reply to comment #20)
> Created attachment 9544 [details]
> Patch created with svn diff after applying the othe patch partly by hand.

Thanks for making the effort to patch the rejects, I assume they were pretty
small.

Unsure what happened to the original patch, I created the patch using
tortoisesvn, I did however do two tweaks to the patch (manually removed from
the patch my makefile customisations and converted tabs to spaces using
notepad++) - I must have mucked something up in the process.

I reviewed your "svn diff" patch, it looks good.
Two note worthy additions came along for the ride:
* svn:eol-style native for the 2 new files - great!
* The change of GTK2 to GTK3 - did you intend to include these?

- Mike

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.