Wireshark-bugs: [Wireshark-bugs] [Bug 7809] Add DigiTech protocol dissection capability.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sun, 4 Nov 2012 19:13:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7809

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #6 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-11-04 19:13:27 PST ---
Coverity CID 741080, "Logically dead code".

Is line 894 supposed to be:

 894        if (digitech_helper > 0x80)

instead of:

 894        if (digitech_helper >= 0x80)


... and btw, can't line 889 be simplified from:

 889    else if (digitech_helper >= 0x80)

to:

 889    else

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.