Wireshark-bugs: [Wireshark-bugs] [Bug 7893] Bluetooth: Add support for AVDTP/A2DP/VDP and SBC co
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893
--- Comment #5 from Michal Labedzki <michal.labedzki@xxxxxxxxx> 2012-11-04 00:07:19 PDT ---
Hello
(In reply to comment #4)
> Hi,
> It would help if you'd split this patch in several; like changes that are not
> debatable and then the other changes.
Ok, I will split it.
> - Why move the codecs dir? I think that was made as it is to make it possible
> to add plugins. To me that blocks this patch as it requires debate.
I moved codecs dir to epan for:
1. Register new codecs in the same way as dissectors, because they are used
similar, see epan/epan.c. In my opinion there is the best place to registering
them.
This was useful to remove unneeded code from (linking with not free library,
also put manually their sources into Wireshark), see ui/gtk/rtp_player.c.
Because there is nice API to register, decode, find, init and release codecs
(see epan/codecs.h).
2. Linking with external library libsbc
3. Audio decoding is another method to dissecting packets. Listening music
instead of read text (Packet Details).
> - The SBC codec is it license free? If not it can't be accepted.
SBC is LGPL. Also I am linking with shared library only if libsbc is detected
in system (by ./configure). Code around SBC in Wireshark is written by me.
> - The other changes looks ok at a glance and could be accepted after review,
> I suggest you split those out.
>
> Regards
> Anders
Ok, thanks.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
