Wireshark-bugs: [Wireshark-bugs] [Bug 7728] Apply as Filter on ieee 802.11 packets gets the filt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 22 Oct 2012 17:30:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728

--- Comment #9 from Evan Huus <eapache@xxxxxxxxx> 2012-10-22 17:30:56 PDT ---
Sorry, this had fallen completely off my radar somehow.

I agree that a subtype field isn't great, but it has the advantage that you can
easily check for "Ethernet of some sort" without caring about which kind or
doing a big long logical OR of all of the different types.

I'm leaning towards explicitly declaring each enum value as a disjoint bitfield
(0x01, 0x02, 0x04, 0x08, etc) and then adding some extra defines such as

#define AT_ETHER_ANY (AT_ETHER_WLAN | AT_ETHER_80211 | ...)

That should get the best of both worlds, as long as the compiler continues to
do switch warnings when the enum values are all hard-coded.

Thoughts?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.